Fixed Import Pictures From Thread To Gallery Not Working

Yes, it is. It uses the defer system to do the work then it could a bit delay but not much. Does it show now?

 

OK. I will try and let you know.

 

Do you have the same add-on above installed?

 

I found the issue. In the query that fetch the selected attachments, it has following condition:

Code:

AND (post.position >= X AND post.position < Y) 

For the first 5 attachments (It get 5 attachments at a time), X will be 0 and Y will be 5. Therefore if the attachments are not from post 1 -> 5, no attachments returned -> return -> nothing imported.

The above condition must be removed.

 

Here is how to fix the issue:

Open the file: library/sonnb/XenGallery/Model/Attachment

Replace the current getAttachmentsForXenGalleryByAttachmentIds method code with the following one:

PHP:

public function getAttachmentsForXenGalleryByAttachmentIds($attachmentIds, array $fetchOptions = array())
    {
        $limitOptions = $this->prepareLimitFetchOptions($fetchOptions);

        return $this->fetchAllKeyed($this->limitQueryResults("
                SELECT attachment.*, attachment_data.*, post.username, post.user_id
                FROM xf_attachment AS attachment
                    LEFT JOIN xf_attachment_data AS attachment_data
                        ON (attachment.data_id = attachment_data.data_id)
                    LEFT JOIN xf_post AS post
                        ON (attachment.content_id = post.post_id)
                WHERE attachment.attachment_id IN (". $this->_getDb()->quote($attachmentIds) .")
                    AND attachment.content_type = 'post'
                    AND post.message_state = 'visible'
                ORDER BY attachment.attachment_id ASC", $limitOptions['limit'], $limitOptions['offset']), 'attachment_id');
    }