1. How to renew my expired license?
    Dismiss Notice
What Do You Need In The Xf2 Xengallery Version? Vote for your choices here: http://www.sonnb.com/threads/what-do-you-need-in-the-xf2-xengallery-version.1539/

Fixed Php 7.2 Support / Fixes

Discussion in 'XenGallery' started by oNdsen, Sep 28, 2018.

  1. oNdsen

    oNdsen Authorized Member Authorized

    Fix:
    library/sonnb/XenGallery/Model/Gallery.php
    Replace Line 223
    PHP:
    while(list($key,$value) = each($aPattern))
    with
    PHP:
    foreach($aPattern AS $key => $value)


    Fix:
    library/sonnb/XenGallery/WidgetRenderer/Album.php
    Replace Line 269
    PHP:
    array_walk($userIds, create_function('&$userId, $key', '$userId = trim($userId);'));
    with
    PHP:
    array_walk($userIds, function(&$userId, $key) {
            $userId = trim($userId);
    });
     
    oNdsen, Sep 28, 2018
    #1
    sonnb, RobinHood and otto like this.
  2. otto

    otto Authorized Member Authorized

    Thanks for sharing this. Its not so fine, the developer not comment this. :(
     
    otto, Dec 2, 2018
    #2
  3. RobinHood

    RobinHood Authorized Member Authorized

    Thanks for the fix
     
    RobinHood, Jun 30, 2019
    #3
  4. sonnb

    sonnb Administrator Staff Member

    I did not realize this thread. Thanks for your post. I will update to the core code.
     
    sonnb, Jul 1, 2019
    #4
    zoldos and RobinHood like this.
  5. sonnb

    sonnb Administrator Staff Member

    I am using 7.2.4 but did not get error so I did not aware of this because these functions are still usable. I have just updated to code locally. Thanks @oNdsen
     
    sonnb, Jul 4, 2019
    #5
    zoldos likes this.
  6. sonnb

    sonnb Administrator Staff Member

    This change was released in 2.6.7.
     
    sonnb, Jul 4, 2019
    #6
    RobinHood and zoldos like this.
  7. zoldos

    zoldos Authorized Member Authorized

    I'm using PHP 7.3.6 and have no errors that I've seen.
     
    zoldos, Jul 4, 2019
    #7
  8. sonnb

    sonnb Administrator Staff Member

    Me either. They are deprecated functions but still usable. But adapting is better since they can be removed in later release.
     
    sonnb, Jul 5, 2019
    #8
    zoldos likes this.
  9. zoldos

    zoldos Authorized Member Authorized

    I went ahead and implemented this patch. I do notice that now I don't have forward/back buttons when viewing videos (viewing pics it works) on Firefox Quantum Developer's Edition. Is this related?
     
    zoldos, Jul 5, 2019
    #9
  10. sonnb

    sonnb Administrator Staff Member

    It is not related. If you got that it means it is existing since an older release.
     
    sonnb, Jul 6, 2019
    #10
    zoldos likes this.
  11. zoldos

    zoldos Authorized Member Authorized

    Okay thanks! :D
     
    zoldos, Jul 6, 2019
    #11
  12. RobinHood

    RobinHood Authorized Member Authorized

    I only saw the errors when I had debug mode enabled. I got a notice at the top of the forum.
     
    RobinHood, Jul 6, 2019
    #12
    sonnb likes this.
  13. zenshare

    zenshare New Member

    i've upgraded to latest version.
     
    zenshare, Oct 18, 2021
    #13
Tags: PHP7.2, create_function, each(), deprecated

Share This Page