Bug With Guest Users

Hi, I'm a techspot.com developer, we are using your addon "sonnb - Stop Spam Here" but I think there is a bug in this addon, if you post in a thread like 'Guest' user, the addon don't validate it. It's related to the register date in the sonnbStopSpamHere_Model_SSH class:

$this->visitor['register_date'] - strtotime('- '.$this->options->sonnbStopSpamHere_linkDisabledJoinDate.' days') > 0

$this->visitor['register_date'] - strtotime('- '.$this->options->sonnbStopSpamHere_keywordDisabledJoinDate.' days') > 0

$this->visitor['register_date'] - strtotime('- '.$this->options->sonnbStopSpamHere_post_disabledJoinDate.' days') > 0

To a guest user, the register_date is always '0', then the 3 lines return a negative number.

 

BTW the solution could be:

Change it:
$this->options->sonnbStopSpamHere_linkDisabledJoinDate &&
$this->visitor['register_date'] - strtotime('- '.$this->options->sonnbStopSpamHere_linkDisabledJoinDate.' days') > 0

By:
$this->options->sonnbStopSpamHere_linkDisabledJoinDate &&
(
!$this->visitor['register_date'] ||
($this->visitor['register_date'] - strtotime('- '.$this->options->sonnbStopSpamHere_linkDisabledJoinDate.' days') > 0)
)

And the same in the other validations.

 

Thank you for considering our bug.

We have this problem because we allow post in (only some) sections without register, then we need protect us from spammers.